Fix meshlet generation, when 32bit indices are forced #660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In MeshProcessor class m_indexSize field should be updated to 4 if 32bit indices are forced and not needed. Before this change the resulting IB was still treated as 16bit afterwards - Finalize<uint16_t> was being called.
|
Definitely a valid fix. AFAIK changes cannot be pulled through GitHub, but have to go through our internal build system and mirrored to here. Aye, @sebmerry? |
|
@mhurliman feel free to review and complete the PR here. We can make sure we replicate the change internally :). |
|
Woooooo - we did it @DziubanMaciej! We're heros |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In MeshProcessor class m_indexSize field should be updated to 4 if 32bit
indices are forced and not needed. Before this change the resulting IB
was still treated as 16bit afterwards - Finalize<uint16_t> was being called.